Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more flexible parametrization #155

Merged
merged 3 commits into from
Sep 1, 2023
Merged

add more flexible parametrization #155

merged 3 commits into from
Sep 1, 2023

Conversation

fnrizzi
Copy link
Member

@fnrizzi fnrizzi commented Sep 1, 2023 •
edited
Loading

as per @cwentland0 's request, this allows to fully parametrize the SWE2d using an unordered map.
the test is self-explanatory

@fnrizzi fnrizzi requested a review from cwentland0 September 1, 2023 21:24
fnrizzi

This comment was marked as outdated.

Sign in to view

@fnrizzi

This comment was marked as outdated.

Sign in to view
@fnrizzi fnrizzi marked this pull request as draft September 1, 2023 23:14
@fnrizzi fnrizzi marked this pull request as ready for review September 1, 2023 23:36
@fnrizzi fnrizzi merged commit b62be53 into develop Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwentland0 cwentland0 cwentland0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
demoapps
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fnrizzi @cwentland0